Conversation
17cc9c4 to
6d6270d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
c95f275 to
aa3b119
Compare
aa3b119 to
ade4859
Compare
|
Locally I got: |
I didn't see those locally. What build steps did you use? |
|
I just used the usual |
|
Main has 363 integration tests. This PR has 204. So we have 159 tests that we need to fix. The classes of tests that we disabled are:
So essential functionality, but it hopefully shouldn't be hard to get it working again, since the code in libasr is available at https://github.com/lcompilers/lpython/tree/635ed2020123199c22f25d3dd23056cd80717762/src/libasr and we just need to port the implementation from it to the newest LPython by:
Before doing some big refactoring or feature in libasr, it's a good idea to first update the submodule to the latest main of LFortran and ensure everything passes. It's a good idea to regularly do this update, to keep in sync. Some other things to fix:
|
PR at LFortran lfortran/lfortran#6780.